feat(cb2-12590): refactor to use async await pattern when sending emails #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Searle <84069850+Daniel-Searle@users.noreply.github.com>
Co-authored-by: Daniel Searle <84069850+Daniel-Searle@users.noreply.github.com>
Co-authored-by: Daniel Searle <84069850+Daniel-Searle@users.noreply.github.com>
Co-authored-by: Daniel Searle <84069850+Daniel-Searle@users.noreply.github.com>
cb-cs
reviewed
Jun 19, 2024
cb-cs
reviewed
Jun 20, 2024
naathanbrown
changed the title
LGin-BJSS
reviewed
Jun 20, 2024
LGin-BJSS
reviewed
Jun 20, 2024
cb-cs
reviewed
Jun 21, 2024
Daniel-Searle
approved these changes
Jun 21, 2024
cb-cs
approved these changes
Jun 21, 2024
m-coslett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket title
Refactor chained promises to async await, change system of emails to fire and forget, increase logging output for debug.
https://dvsa.atlassian.net/browse/CB2-12590
Checklist