Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CB2-12690): added activities and test results types #123

Merged
merged 12 commits into from
Jul 12, 2024
Merged

feat(CB2-12690): added activities and test results types #123

merged 12 commits into from
Jul 12, 2024

Conversation

Daniel-Searle
Copy link
Contributor

@Daniel-Searle Daniel-Searle commented Jul 4, 2024 •
edited
Loading

Implement types-definition into atf-report-gen service

This change is to implement the types definition into this repository,
CB2-12690

Checklist

  • Branch is rebased against the latest develop
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Link to the PR added to the repo

@Daniel-Searle Daniel-Searle marked this pull request as ready for review July 4, 2024 11:16
@m-coslett m-coslett self-requested a review July 4, 2024 13:12
m-coslett
m-coslett reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@m-coslett m-coslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the any data type in the reportGen function
Remove the ACTIVITY_TYPE enum and replace the usages with the type definition

src/models/index.d.ts Outdated Show resolved Hide resolved
cb-cs
cb-cs reviewed Jul 4, 2024
View reviewed changes
src/services/SendATFReport.ts Outdated Show resolved Hide resolved
@Daniel-Searle Daniel-Searle requested a review from cb-cs July 5, 2024 10:38
@Daniel-Searle Daniel-Searle requested a review from m-mullen July 5, 2024 13:03
m-mullen
m-mullen reviewed Jul 5, 2024
View reviewed changes
src/models/index.d.ts Outdated Show resolved Hide resolved
src/services/SendATFReport.ts Show resolved Hide resolved
m-mullen
m-mullen previously approved these changes Jul 8, 2024
View reviewed changes
cb-cs
cb-cs reviewed Jul 8, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Daniel-Searle Daniel-Searle requested review from m-mullen and cb-cs July 8, 2024 10:03
cb-cs
cb-cs previously approved these changes Jul 8, 2024
View reviewed changes
m-mullen
m-mullen previously approved these changes Jul 8, 2024
View reviewed changes
@Daniel-Searle Daniel-Searle dismissed stale reviews from m-mullen and cb-cs via 8e41dd6 July 9, 2024 08:40
@m-coslett m-coslett self-requested a review July 12, 2024 09:56
@Daniel-Searle Daniel-Searle merged commit a81d474 into develop Jul 12, 2024
7 checks passed
@Daniel-Searle Daniel-Searle deleted the feature/CB2-12690 branch July 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mullen m-mullen m-mullen approved these changes

@m-coslett m-coslett m-coslett approved these changes

@cb-cs cb-cs cb-cs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daniel-Searle @m-coslett @cb-cs @m-mullen