Mes-9450: rekey reason cp #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
RLCorp
added a commit
that referenced
this pull request
Apr 9, 2024
…age (#1554) * add GA4 analytics for practice mode journal (#1532) * mes-release-9350-passFinalGA4 (#1534) * Added Ga4 to pass finalisation page * Corrected use of incorrect code * removed unneeded change * add GA4 analytics for pass certificate (#1536) * Post defrief ga4 cp (#1541) * add GA4 analytics for post debrief * use correct prefix * mes-release-PrefixTaggingGA4 (#1542) * Added correct pre-fixes to vehicle checks * Added correct pre-fixes to Office and pass finalisation * mes-release-9350-FailFinalGA4 (#1544) * Added GA4 for non-pass Finalisation * Added correct pre-fixes to nonpass finalisation * Mes-9450: rekey reason cp (#1546) * GA4 analytics for rekey reason * add test, fix screen name issue * Added Ga4 to reverse diagram (#1545) * migrated GA4 analytics for rekey search (#1548) * migrated GA4 analytics for rekey upload outcome (#1552) * Added guard to element language change functionality (#1551) * Added padding to radio to make it more in line with the rest of the page --------- Co-authored-by: andrewsetterfield <48550267+andrewsetterfield@users.noreply.github.com>
RLCorp
added a commit
that referenced
this pull request
Jun 24, 2024
* add GA4 analytics for practice mode journal (#1532) * mes-release-9350-passFinalGA4 (#1534) * Added Ga4 to pass finalisation page * Corrected use of incorrect code * removed unneeded change * add GA4 analytics for pass certificate (#1536) * Post defrief ga4 cp (#1541) * add GA4 analytics for post debrief * use correct prefix * mes-release-PrefixTaggingGA4 (#1542) * Added correct pre-fixes to vehicle checks * Added correct pre-fixes to Office and pass finalisation * mes-release-9350-FailFinalGA4 (#1544) * Added GA4 for non-pass Finalisation * Added correct pre-fixes to nonpass finalisation * Mes-9450: rekey reason cp (#1546) * GA4 analytics for rekey reason * add test, fix screen name issue * Added Ga4 to reverse diagram (#1545) * migrated GA4 analytics for rekey search (#1548) * migrated GA4 analytics for rekey upload outcome (#1552) * Added guard to element language change functionality (#1551) * Added padding to radio to make it more in line with the rest of the page (#1554) * add GA4 analytics for practice mode journal (#1532) * mes-release-9350-passFinalGA4 (#1534) * Added Ga4 to pass finalisation page * Corrected use of incorrect code * removed unneeded change * add GA4 analytics for pass certificate (#1536) * Post defrief ga4 cp (#1541) * add GA4 analytics for post debrief * use correct prefix * mes-release-PrefixTaggingGA4 (#1542) * Added correct pre-fixes to vehicle checks * Added correct pre-fixes to Office and pass finalisation * mes-release-9350-FailFinalGA4 (#1544) * Added GA4 for non-pass Finalisation * Added correct pre-fixes to nonpass finalisation * Mes-9450: rekey reason cp (#1546) * GA4 analytics for rekey reason * add test, fix screen name issue * Added Ga4 to reverse diagram (#1545) * migrated GA4 analytics for rekey search (#1548) * migrated GA4 analytics for rekey upload outcome (#1552) * Added guard to element language change functionality (#1551) * Added padding to radio to make it more in line with the rest of the page --------- Co-authored-by: andrewsetterfield <48550267+andrewsetterfield@users.noreply.github.com> * CP MES-9336 (#1555) * Added GA4 Analytics to test report for actions relating to Cat B * PR comment amendments & test fixes * migrated GA4 analytics for test report dashboard (#1557) * mes-9545-release-testsAnalyticsGA4 (#1560) * Added GA4 to store tests * Added additional tests * Test status ga4 cp (#1561) * migrated GA4 analytics for test status * corrected event type * update label (#1564) * Recapitalised integrity marker (#1565) * Mes-9360: cherry pick (#1568) * Completed GA4 for rest of test-report analytics files & tests * Additional tests for previously un-tested functions * amended incorrect events along with corresponding tests * changed to use ModalReason values instead * cp and update version --------- Co-authored-by: ryan <ryan_gittins_33@hotmail.co.uk> * mes-release-languageFix (#1574) * Added additional guards to language directive code * Fixed tests * removed log * bump version * Mes-9489: custom analytics (#1578) * WIP * removed unused code * failing tests * corrected tests * guard against calling journal if delegated user (#1581) * version bump (#1582) * Fixed button changing colour to dark blue on hold (#1583) * Allow burger menu items to scale when text sizes are changed (#1584) * Added function to get label for driving faults (#1585) Co-authored-by: ryan <ryan_gittins_33@hotmail.co.uk> * Fixed visuals on mod1 code-4 modal (#1586) * mes-9491: change where user id is set in GA4 (#1588) * change where user id is set in GA4 * restore the config setting for user id * version bump to 4.11.0.4 (#1591) * update to allow partially completed tests to be included with the journal restore (#1593) * version bump (#1594) * upped versions to 4.12.1.0 * Mes 4.12.1 analytics (#1631) * Various Analytics fixes * Fixed tests * update ga value for post method * added reference to enum --------- Co-authored-by: andrew setterfield <andrew.setterfield@dvsa.gov.uk> * update fastfile ref (#1632) * Removed unneeded analytic (#1635) * version bump (#1637) * updated analytics (#1638) * updated analytics with prefixes and remove duplicates. (#1640) * update analytics for return to test (#1642) * Changed ADI & SC question events to include question number in event name & changed title used to QUESTION_SCORE instead of QUESTION_NUMBER (#1634) * Mes-8978: delegated future test modal (#1646) * Included new function to check if a rekey takes place is the future and displays a modal if it does * Fixed tests * Removed time from the equation to calculate whether a test takes place in the future. --------- Co-authored-by: Rhys Lewis <rhys.lewis@dvsa.gov.uk> * Revert "Mes-8978: delegated future test modal (#1646)" (#1649) This reverts commit dd7083c. * Corrected analytics for faults (#1647) * Included new function to check if a rekey takes place is the future and displays a modal if it does * Fixed tests * Removed time from the equation to calculate whether a test takes place in the future. * Changed design and added functionality to clear page on close * Minor formatting changes --------- Co-authored-by: andrewsetterfield <48550267+andrewsetterfield@users.noreply.github.com> Co-authored-by: Ryan Gittins <45790769+gittins7@users.noreply.github.com> Co-authored-by: ryan <ryan_gittins_33@hotmail.co.uk> Co-authored-by: andrew setterfield <andrew.setterfield@dvsa.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots (optional)