Skip to content

Commit

Permalink
GHA: Install benchmark collection only where necessary
Browse files Browse the repository at this point in the history
... and get rid of the URLs in pyproject.toml that aren't allowed on PyPI
  • Loading branch information
dweindl committed Oct 1, 2024
1 parent 99a1636 commit fa22eb8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/deploy_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ jobs:

- run: echo "AMICI_DIR=$(pwd)" >> $GITHUB_ENV

- name: Remove direct dependencies from setup.cfg
# Remove any "git+https"-based dependencies that are not supported
# by PyPI and are only required for testing.
run: sed -i '/git+https/d' python/sdist/pyproject.toml

- name: sdist
run: scripts/buildSdist.sh

Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/test_python_cplusplus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,12 @@ jobs:
path: ${{ env.pooch-cache }}
key: ${{ runner.os }}-py${{ matrix.python-version }}-${{ github.job }}

- name: Install PEtab benchmark collection
run: |
git clone --depth 1 https://github.com/benchmarking-initiative/Benchmark-Models-PEtab.git \
&& export BENCHMARK_COLLECTION="$(pwd)/Benchmark-Models-PEtab/Benchmark-Models/" \
&& source venv/bin/activate && python -m pip install -e $BENCHMARK_COLLECTION/../src/python
- name: Python tests
run: |
scripts/run-python-tests.sh \
Expand Down
1 change: 0 additions & 1 deletion python/sdist/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ classifiers = [
petab = ["petab>=0.4.0"]
pysb = ["pysb>=1.13.1"]
test = [
"benchmark_models_petab @ git+https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab.git@master#subdirectory=src/python",
"h5py",
"pytest",
"pytest-cov",
Expand Down

0 comments on commit fa22eb8

Please sign in to comment.