Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old cordova iOS icons #53

Open
MajorBreakfast opened this issue Jan 10, 2018 · 3 comments
Open

Delete old cordova iOS icons #53

MajorBreakfast opened this issue Jan 10, 2018 · 3 comments

Comments

@MajorBreakfast
Copy link

MajorBreakfast commented Jan 10, 2018

I'm using this tool to generate my iOS icons. I looked into the AppIcon.appiconset/ directory and I see that the default cordova icon files are still in the folder after running the tool. It would be best if those files were removed, because they're no longer needed.

BTW Thanks for creating this tool!

@dwmkerr
Copy link
Owner

dwmkerr commented Jan 18, 2018

Thanks for the note! Yes it would make sense to clean them up, but perhaps only when a flag is set, to avoid people inadvertently losing anything. Will look into this for the next release.

@MajorBreakfast
Copy link
Author

A flag is not necessarily needed. Here're two ideas:

  • https://www.npmjs.com/package/trash It's an npm package that moves files into the trash instead of deleting them outright (cross plattform).
  • Or (better I think): Detect whether the files are the default cordova boilerplate icons via their sha1 hash and then delete them without asking. No one needs the boilerplate icons in their app. :D

@dwmkerr
Copy link
Owner

dwmkerr commented Jan 24, 2018

Nice ideas, will check them both out and see what I can do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants