Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building modsurfer as wasm #73

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Apr 9, 2024

This only fixes building as wasm32-unknown-unknown, major updates need to be done if we need to build this as wasm32-wasi. For consistently reasons, target_os = "unknown" was specified.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024

CLA assistant check
All committers have signed the CLA.

@G4Vi G4Vi requested a review from zshipko April 9, 2024 16:16
Copy link

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@G4Vi G4Vi merged commit ff8210c into main Apr 9, 2024
37 checks passed
@G4Vi G4Vi deleted the fix-building-modsurfer-as-wasm branch April 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants