Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add path to NormalizeError and ParseError #5

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Conversation

mhmd-azeez
Copy link
Contributor

@mhmd-azeez mhmd-azeez commented Sep 2, 2024

This makes it easier to use the library in our schema plugin

Related to https://github.com/dylibso/xtp/issues/730

@mhmd-azeez mhmd-azeez marked this pull request as draft September 2, 2024 14:35
@evacchi
Copy link

evacchi commented Sep 3, 2024

somewhat related to dylibso/xtp-go-bindgen#14

Copy link

@evacchi evacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kiss:

@mhmd-azeez mhmd-azeez marked this pull request as ready for review September 3, 2024 16:23
src/normalizer.ts Outdated Show resolved Hide resolved
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor suggestion, otherwise excellent improvements here!!

@mhmd-azeez mhmd-azeez merged commit 2dcdbd2 into main Sep 4, 2024
3 checks passed
@mhmd-azeez mhmd-azeez deleted the error-location branch September 4, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants