Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crux-ui): useEffect submitRef update #806

Merged
merged 7 commits into from
Sep 6, 2023

Conversation

robot9706
Copy link
Contributor

  • Refactor submitRef updates to use useEffect, this should resolve save/edit test flakyness.
  • Fix an issue where unchecked registries try to fetch images on the registry detail page.

@robot9706 robot9706 requested a review from a team as a code owner September 1, 2023 08:36
@robot9706 robot9706 self-assigned this Sep 1, 2023
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:typescript and removed pr:feat labels Sep 1, 2023
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

@m8vago
Copy link
Contributor

m8vago commented Sep 1, 2023

It would be nice to write a custom hook and use that instead.

@robot9706
Copy link
Contributor Author

@m8vago Added the submitRef to useDyoFormik as an optional parameter. But it might be better to have a separate hook because this way there's an extra effect which does nothing if there's no submitRef, but this seemed convenient. Thoughts?

@m8vago
Copy link
Contributor

m8vago commented Sep 1, 2023

Great job! There is no point to use it without a form, and we don't have forms without formik, so that's the best place for it.

web/crux-ui/src/hooks/use-dyo-formik.ts Outdated Show resolved Hide resolved
@polaroi8d polaroi8d merged commit a014619 into develop Sep 6, 2023
25 checks passed
@polaroi8d polaroi8d deleted the feat/use-effect-submitref branch September 6, 2023 04:42
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:typescript pr:feat severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants