Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageref route): add route to mappedPageRef #201

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

neo-reply-lukas
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@nico-mcalley nico-mcalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case for this feature / the navigation data is no possible solution?

@neo-reply-lukas
Copy link
Collaborator Author

Exactly the case, where you have a pageRef but not its NavigationData at hand. Of course, one could make a subsequent call to NavService, but the required Info is right there

@neo-reply-lukas
Copy link
Collaborator Author

Additionally it's in line with the current Dataset Mapping, where route and routes get mapped as well

@nico-mcalley nico-mcalley merged commit f60ae62 into master Mar 4, 2024
3 checks passed
@nico-mcalley nico-mcalley deleted the AddRouteToPage branch March 4, 2024 06:53
github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
# [10.20.0](v10.19.1...v10.20.0) (2024-03-04)

### Features

* **pageref route:** add route to mappedPageRef ([#201](#201)) ([f60ae62](f60ae62))
Copy link

github-actions bot commented Mar 4, 2024

🎉 This PR is included in version 10.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants