Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Angular Material #42

Merged
merged 9 commits into from
Feb 19, 2023
Merged

feat: add Angular Material #42

merged 9 commits into from
Feb 19, 2023

Conversation

Danieliverant
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] Other... Please describe: Infra

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[X] Yes
[ ] No

Won't impact

Other information

@nx-cloud
Copy link

nx-cloud bot commented Feb 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eefdd2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@ronnetzer
Copy link
Member

instead of feat(global): you should just do feat:

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #42 (eefdd2b) into master (79cad0b) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   61.53%   61.78%   +0.24%     
==========================================
  Files          23       23              
  Lines         156      157       +1     
  Branches       12       12              
==========================================
+ Hits           96       97       +1     
  Misses         60       60              
Flag Coverage Δ *Carryforward flag
cli-daemon 51.45% <ø> (ø)
cli-gui 81.48% <100.00%> (+0.34%) ⬆️
shared ∅ <ø> (∅) Carriedforward from 063a8df

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
apps/cli-gui/src/app/app.component.html 100.00% <ø> (ø)
apps/cli-gui/src/app/app.component.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
apps/cli-gui/src/main.ts Outdated Show resolved Hide resolved
@ronnetzer ronnetzer changed the title feat(global): add Angular Material feat: add Angular Material Feb 19, 2023
@Danieliverant Danieliverant merged commit dcb5443 into master Feb 19, 2023
@Danieliverant Danieliverant linked an issue Feb 19, 2023 that may be closed by this pull request
@ronnetzer ronnetzer deleted the daniel/material branch February 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular material theme
3 participants