Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all AssumptionViolationExceptions in the non-testing code #47

Closed
maxkratz opened this issue Dec 7, 2023 · 1 comment
Closed

Remove all AssumptionViolationExceptions in the non-testing code #47

maxkratz opened this issue Dec 7, 2023 · 1 comment
Assignees
@maxkratz
Labels
bug Something isn't working

Comments

@maxkratz
Copy link
Member

maxkratz commented Dec 7, 2023

Currently, some of the internal checks throw an AssumptionViolationException. This kind of exception will not fail any JUnit tests; therefore, we should change it to something else.
@maxkratz maxkratz added the bug Something isn't working label Dec 7, 2023
@maxkratz maxkratz self-assigned this Dec 7, 2023
@maxkratz maxkratz mentioned this issue Dec 8, 2023
Merged
@maxkratz
Copy link
Member Author

maxkratz commented Dec 8, 2023

Closed via #48.

@maxkratz maxkratz closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxkratz maxkratz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxkratz