Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing format method and load method implementation #197

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Add missing format method and load method implementation #197

merged 4 commits into from
Nov 4, 2024

Conversation

eredzik
Copy link
Contributor

@eredzik eredzik commented Nov 1, 2024

Needed for compatibility purposes, simple implementation of these methods for available data sources (json and parquet)

@eredzik eredzik requested a review from eakmanrq as a code owner November 1, 2024 08:45
eakmanrq
eakmanrq reviewed Nov 2, 2024
View reviewed changes
sqlframe/base/mixins/readwriter_mixins.py Outdated Show resolved Hide resolved
sqlframe/base/readerwriter.py Outdated Show resolved Hide resolved
eakmanrq
eakmanrq approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@eakmanrq eakmanrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eredzik!

@eakmanrq eakmanrq merged commit 8292241 into eakmanrq:main Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eakmanrq eakmanrq eakmanrq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eredzik @eakmanrq