-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update hooks documentation to cover new hooks: pre_build_and_install_loop_hook
, post_build_and_install_loop_hook
, pre_postiter_hook
, post_postiter_hook
, cancel_hook
, fail_hook
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branfosj
previously requested changes
Aug 9, 2023
Notes:
|
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Not sure why it is saying the changes aren't addressed? |
boegel
changed the title
Update hooks page to include undocumented hooks, as well as new ones.
update hooks documentation to cover new hooks: Aug 31, 2023
pre_build_and_install_loop
, post_build_and_install_loop
, pre_postiter_hook
, post_postiter_hook
, cancel_hook
, fail_hook
boegel
approved these changes
Aug 31, 2023
… as intended + minor cleanup
boegel
changed the title
update hooks documentation to cover new hooks:
update hooks documentation to cover new hooks: Aug 31, 2023
pre_build_and_install_loop
, post_build_and_install_loop
, pre_postiter_hook
, post_postiter_hook
, cancel_hook
, fail_hook
pre_build_and_install_loop_hook
, post_build_and_install_loop_hook
, pre_postiter_hook
, post_postiter_hook
, cancel_hook
, fail_hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_and_install_loop
hooks- I am unsure about thepostiter
hook and what it does, and whether it even has pre and post variationspostiter
seems to be not callable, thus I have remove it.postiter
will be implemented in a future version, adding to docs...