Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hooks documentation to cover new hooks: pre_build_and_install_loop_hook, post_build_and_install_loop_hook, pre_postiter_hook, post_postiter_hook, cancel_hook, fail_hook #208

Merged
merged 11 commits into from
Aug 31, 2023

Conversation

XavierCS-dev
Copy link
Contributor

@XavierCS-dev XavierCS-dev commented Aug 9, 2023

  • Includes failure hooks, as well as build_and_install_loop hooks
  • Detail information about hook parameters.
  • Correct some small typos.
    - I am unsure about the postiter hook and what it does, and whether it even has pre and post variations
    postiter seems to be not callable, thus I have remove it.
    postiter will be implemented in a future version, adding to docs...

@XavierCS-dev XavierCS-dev marked this pull request as ready for review August 9, 2023 12:46
docs/hooks.md Outdated Show resolved Hide resolved
docs/hooks.md Outdated Show resolved Hide resolved
docs/hooks.md Outdated Show resolved Hide resolved
docs/hooks.md Outdated Show resolved Hide resolved
XavierCS-dev and others added 4 commits August 9, 2023 14:11
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
@boegel boegel added enhancement New feature or request update labels Aug 9, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 9, 2023
@XavierCS-dev
Copy link
Contributor Author

Not sure why it is saying the changes aren't addressed?

@boegel boegel changed the title Update hooks page to include undocumented hooks, as well as new ones. update hooks documentation to cover new hooks: pre_build_and_install_loop, post_build_and_install_loop, pre_postiter_hook, post_postiter_hook, cancel_hook, fail_hook Aug 31, 2023
@boegel boegel dismissed branfosj’s stale review August 31, 2023 07:14

requested changes made

@boegel boegel changed the title update hooks documentation to cover new hooks: pre_build_and_install_loop, post_build_and_install_loop, pre_postiter_hook, post_postiter_hook, cancel_hook, fail_hook update hooks documentation to cover new hooks: pre_build_and_install_loop_hook, post_build_and_install_loop_hook, pre_postiter_hook, post_postiter_hook, cancel_hook, fail_hook Aug 31, 2023
@boegel boegel merged commit eca3259 into easybuilders:develop Aug 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants