Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distutils use from setup.py #4478

Draft
wants to merge 4 commits into
base: 5.0.x
Choose a base branch
from

Conversation

bartoldeman
Copy link
Contributor

Use logging and setuptools instead.

@bartoldeman
Copy link
Contributor Author

This is very minimal, but it does allow python setup.py xxx for Python 3.12 (tried sdist and install) with setuptools installed.

Using pyproject.toml and PEP517 would take it a few steps further.
See #3963

@bartoldeman bartoldeman added this to the 5.0 milestone Mar 7, 2024
setup.py Outdated Show resolved Hide resolved
@boegel boegel changed the title Remove distutils use from setup.py. Remove distutils use from setup.py Mar 11, 2024
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@bartoldeman
Copy link
Contributor Author

Note: this change isn't needed for pip install easybuild-framework since that'll use distutils from an internal temporary installation of setuptools, the direct setuptools dependency only seems to come in when you run python setup.py directly, and in that case installing setuptools makes setup.py work without this change...

@bartoldeman bartoldeman marked this pull request as draft March 11, 2024 16:12
@boegel
Copy link
Member

boegel commented Mar 13, 2024

@bartoldeman Any reason this is still a draft PR?

@bartoldeman
Copy link
Contributor Author

I don't think we need it:
a) we don't need it for pip, since pip installs setuptools and hence import distutils works inside pip
b) we don't need it for setup.py directly, since if you install setuptools anyway you can just import distutils

@boegel
Copy link
Member

boegel commented Mar 27, 2024

#4484 confirms we don't need these changes, so closing...

@boegel boegel closed this Mar 27, 2024
@haampie
Copy link

haampie commented Nov 14, 2024

I don't think we need it: a) we don't need it for pip, since pip installs setuptools and hence import distutils works inside pip b) we don't need it for setup.py directly, since if you install setuptools anyway you can just import distutils

This is a popular false belief :)

cython/cython#5754 (comment)

can you reopen @boegel?

@boegel
Copy link
Member

boegel commented Nov 14, 2024

@bartoldeman Can you look into this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Blockers
Development

Successfully merging this pull request may close these issues.

3 participants