Fix to_numeric() with inversed factor levels
#663
strengejackelint-changed-files.yaml
on: pull_request
lint-changed-files
/
lint-changed-files
2m 37s
Annotations
1 error and 3 warnings
|
lint-changed-files / lint-changed-files
Process completed with exit code 31.
|
|
lint-changed-files / lint-changed-files:
R/data_tabulate.R#L182
file=R/data_tabulate.R,line=182,col=9,[if_not_else_linter] In a simple if/else statement, prefer `if (A) x else y` to the less-readable `if (!A) y else x`.
|
|
lint-changed-files / lint-changed-files:
R/data_tabulate.R#L229
file=R/data_tabulate.R,line=229,col=7,[nzchar_linter] Instead of comparing strings to "", use nzchar(). Note that if x is a factor, you'll have use as.character() to replicate an implicit conversion that happens in x == "". Whenever missing data is possible, please take care to use nzchar(., keepNA = TRUE); nzchar(NA) is TRUE by default.
|
|
lint-changed-files / lint-changed-files:
R/to_numeric.R#L94
file=R/to_numeric.R,line=94,col=5,[object_overwrite_linter] 'args' is an exported object from package 'base'. Avoid re-using such symbols.
|