Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect roxygen import tags in a single location #304

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

IndrajeetPatil
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #304 (6f72d51) into main (eccd98c) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f72d51 differs from pull request most recent head 14415cd. Consider uploading reports for the commit 14415cd to get more accurate results

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   44.32%   44.32%           
=======================================
  Files          66       66           
  Lines        4742     4742           
=======================================
  Hits         2102     2102           
  Misses       2640     2640           
Files Changed Coverage Δ
R/geom_violindot.R 40.00% <ø> (ø)
R/geom_violinhalf.R 100.00% <ø> (ø)
R/plot.bayesfactor_parameters.R 0.00% <ø> (ø)
R/plot.binned_residuals.R 0.00% <ø> (ø)
R/plot.check_collinearity.R 94.73% <ø> (ø)
R/plot.check_homogeneity.R 70.58% <ø> (ø)
R/plot.check_model.R 0.00% <ø> (ø)
R/plot.compare_performance.R 97.61% <ø> (ø)
R/plot.estimate_contrasts.R 97.67% <ø> (ø)
R/plot.estimate_density.R 46.87% <ø> (ø)
... and 10 more

@bwiernik
Copy link
Contributor

I think it's fine to just import ggplot2 once in see, but in general I prefer that any imports be next to the code that actually uses them. We rarely import functions anyway vs namespacing them

@IndrajeetPatil
Copy link
Member Author

We rarely import functions anyway vs namespacing them

Fair enough! Maybe we won't even need to do this for any other repo other than {see}.

@IndrajeetPatil IndrajeetPatil merged commit 7f4b83b into main Sep 17, 2023
21 of 26 checks passed
@IndrajeetPatil IndrajeetPatil deleted the single-imports-location branch September 17, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants