-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot.n_factors: Add % of variance to plot #314
Conversation
So the basic message is that using 4 or more factors does not significantly increase the explained variance? |
Yes, although variance explained is only used for a subset of methods to determine the optimal number of factors (so it's not the only thing that impact the result of the n methods that we test) but it's quite standard procedure to report it when we do EFA, and it's one of these "intuitive" index. |
This reverts commit 4c12bbf.
should I merge? |
Can you please have a look at the build failures? Workflows that are passing on the default branch are failing here. |
Is this new and probably related to the last changes?
|
This error is a mystery to me. Quitting from lines 284-294 [unnamed-chunk-22] (parameters.Rmd)
Error in `map()`:
ℹ In index: 6.
ℹ With name: vignettes/parameters.Rmd.
Caused by error in `seq_len()`:
! (converted from warning) first element used of 'length.out' argument
Backtrace:
1. parameters::model_parameters(ma)
2. parameters:::model_parameters.rma(ma)
at parameters/R/1_model_parameters.R:301:3
3. parameters:::.model_parameters_generic(...)
at parameters/R/methods_metafor.R:76:3
...
at parameters/R/1_model_parameters.R:622:3
5. parameters:::.format_value_labels(params, model)
at parameters/R/utils_model_parameters.R:62:3
6. insight::get_data(model, source = "mf", verbose = FALSE)
at parameters/R/format_parameters.R:372:5
Execution halted |
Else, there seem to be no other failing checks related to this PR. |
Should be non-breaking and work with easystats/parameters#921