Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return class of check_model() patchwork #339

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

bwiernik
Copy link
Contributor

@bwiernik
Copy link
Contributor Author

The R CMD Checks look good--not sure about the other workflows

@bwiernik
Copy link
Contributor Author

@strengejacke the issue was that apparently invisible() doesn't also return unless it's the last line of the function and gets the implicit return. I didn't realize that

@strengejacke
Copy link
Member

The R CMD Checks look good--not sure about the other workflows

I think you can ignore the other workflows. They error due to warnings which are hard to silence.
@IndrajeetPatil do you have any ideas how to handle the failing workflows?

@strengejacke strengejacke merged commit 5682cc0 into main Apr 18, 2024
18 of 25 checks passed
@strengejacke strengejacke deleted the patchwork-fix branch April 18, 2024 19:45
@IndrajeetPatil
Copy link
Member

We just need to fix the new warnings generated by ggplot2 3.5.0; I am waiting for ggplot2 3.5.1, which would silence some of these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot apply check_model title with patchwork::plot_annotation
3 participants