Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot.parameters_simulate formatting VS parameters_model formatting #367

Merged
merged 6 commits into from
Sep 29, 2024

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Sep 29, 2024

Fixes #278
Fixes #264
Fixes #265
Fixes #235

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.58%. Comparing base (c89dcb1) to head (3d4383a).

Files with missing lines Patch % Lines
R/plot.parameters_simulate.R 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   46.57%   46.58%           
=======================================
  Files          68       68           
  Lines        5262     5266    +4     
=======================================
+ Hits         2451     2453    +2     
- Misses       2811     2813    +2     
Flag Coverage Δ
46.58% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke strengejacke merged commit 24d57f1 into main Sep 29, 2024
21 of 22 checks passed
@strengejacke strengejacke deleted the strengejacke/issue278 branch September 29, 2024 13:47
@IndrajeetPatil
Copy link
Member

Wow. Thanks, Daniel!

@strengejacke
Copy link
Member Author

I looked at the issues as I was waiting for checks, and thought the other issues looked rather quick to address, and finally I had 4 issues in one PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment