Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update organism Canis lupus familiaris to match Ensembl #53

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

irisdianauy
Copy link
Contributor

Ensembl has been using Canis lupus familiaris and equivalent canis_lupus_familiaris code since release 100. This PR updates annotations to match Ensembl.

@pcm32
Copy link
Member

pcm32 commented Sep 28, 2022

@alfonsomunozpomer could you comment on what could be the repercussions of this change in the web app? We need this change for the newer indexing setup.

@alfonsomunozpomer
Copy link
Member

@alfonsomunozpomer could you comment on what could be the repercussions of this change in the web app? We need this change for the newer indexing setup.

As long as this change propagates to Solr collections (e.g. bulk-analtyics and bioentities), as well as the organism field in the SDRF file and the experiments table in Postgres that’s alright.

If that’s not possible then we need to change somewhat the logic, since we’re already applying some custom rules for this particular case:
https://github.com/ebi-gene-expression-group/atlas-web-core/blob/develop/src/main/java/uk/ac/ebi/atlas/species/SpeciesPropertiesTrader.java#L119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants