Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create galaxy-bioblend container #142

Merged
merged 7 commits into from
May 10, 2024
Merged

Conversation

anilthanki
Copy link
Contributor

No description provided.

@anilthanki anilthanki requested a review from pcm32 May 9, 2024 13:26
@pcm32
Copy link
Member

pcm32 commented May 9, 2024

didn't this require pyaml as well? Or if this is a dependency of bioblend, I'm surprised it is not in the biocontainers container.

@pcm32
Copy link
Member

pcm32 commented May 9, 2024

and possibly some library to connect to S3?

@pcm32
Copy link
Member

pcm32 commented May 9, 2024

On the container tag, I would suggest following the main package version (ie bioblend).

Copy link
Member

@pcm32 pcm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are all the dependencies that you need, then it should be fine. I would suggest using 1.1.1 as version of the container (you can alway increases patch version for newer container versions of the same package).

@pcm32
Copy link
Member

pcm32 commented May 9, 2024

Remember this before merging.

@anilthanki
Copy link
Contributor Author

didn't this require pyaml as well? Or if this is a dependency of bioblend, I'm surprised it is not in the biocontainers container.

When I tried locally Yaml got installed as dependency, as it should but suddenly it started missing from our original setup in PS

  yaml               conda-forge/osx-arm64::yaml-0.2.5-h3422bc3_2

@anilthanki
Copy link
Contributor Author

and possibly some library to connect to S3?

On Jenkins it gives following error

package bioblend-0.14.0-py_0 requires boto >=2.9.7, but none of the providers can be installed

but when trying locally (on ARM chip) it can be installed without any issue

boto3              conda-forge/noarch::boto3-1.34.100-pyhd8ed1ab_0

@anilthanki anilthanki merged commit badffe6 into master May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants