Bugfix/characteristic column may contain space in sdrf file #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/load_exp_design.sh
Outdated
Comment on lines
19
to
20
| FactorArray=( FactorValue "Factor Value" "Factor Value " "FactorValue ") | ||
| CharacteristicsArray=( Characteristics "Characteristics " ) |
There was a problem hiding this comment.
I’m not the designated reviewer, but I think pattern matching is a more robust solution.
|
Sorry I neglected this one for a while. Could you please add tests with their respective SDRF files in the |
alfonsomunozpomer
requested changes
Jul 3, 2023
ke4
deleted the
bugfix/characteristic-column-may-contain-space-in-sdrf-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have un-normalised sdrf column titles for factor and characteristics