Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nice strings for DIMRED_TYPE #66

Closed
wants to merge 2 commits into from
Closed

Use nice strings for DIMRED_TYPE #66

wants to merge 2 commits into from

Conversation

alfonsomunozpomer
Copy link
Member

To be consistent with the V19 migration in atlas-schemas.

@alfonsomunozpomer
Use nice strings for DIMRED_TYPE
bc40ee7 
To be consistent with the V19 migration in `atlas-schemas`.
pmb59
pmb59 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@pmb59 pmb59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsomunozpomer LGTM!

pmb59 added a commit that referenced this pull request Sep 14, 2023
@pmb59
Related to PR #66
fa23a2a
pmb59 added a commit that referenced this pull request Oct 10, 2023
@pmb59
dirname: missing operand error in SCXA loading due to undefined $BASH…
6326500 
…_SOURCE (#68)

* Update load_db_scxa_dimred.sh

* using ${BASH_SOURCE:-$0}  to avoid cases where BASH_SOURCE is not defined

* edit SCRATCH_DIR in bin/load_db_scxa_dimred.sh

* Related to PR #66
@pmb59
Copy link
Member

pmb59 commented Oct 17, 2023

Due to loading needs, this fix was implement in the PR #66

@pmb59 pmb59 closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmb59 pmb59 pmb59 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfonsomunozpomer @pmb59