Turn off autocomplete for text inputs #1612
Merged
+90
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSMM updates to use Chrome v131, which causes awkward autocomplete popups to be shown for text inputs. This seemed to affect only inputs with ids, but not all of them. To avoid regressions if ids would be added later, they were added now, paired with the autocomplete="off" attribute. As an additional benefit, this makes it easier to interpret errors TSMM logs into Sentry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSMM updates to use Chrome v131, which causes awkward autocomplete popups to be shown for text inputs. This seemed to affect only inputs with ids, but not all of them. To avoid regressions if ids would be added later, they were added now, paired with the autocomplete="off" attribute. As an additional benefit, this makes it easier to interpret errors TSMM logs into Sentry.