Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ecc 5069 link ids event to kg #137

Merged
merged 17 commits into from
Jul 6, 2023

Conversation

rpietzsch
Copy link
Contributor

@rpietzsch rpietzsch commented Jul 6, 2023

This is a urgent merge request from @BorderCloud . Some of her clients are waiting for this tutorial top become available. I harmonized md markup and fixed some numbering and indentation. But it requires more attention and effort, IMHO:

  • Some chapter are super complex / long. Here I am not sure if the indentation is fully correct and reflect how the paragraphs and elements should belong together.
  • English could and should be improved.

I suggest we either merge it to have it available at dev. only for the time being and/or remove the .pageentry so @BorderCloud can sent a deep-link at least.

@rpietzsch rpietzsch self-assigned this Jul 6, 2023
@rpietzsch
Copy link
Contributor Author

rpietzsch commented Jul 6, 2023

.drawio files could be saved as .drawio.[png|svg] to have asset and source in one place.
cf: https://marketplace.visualstudio.com/items?itemName=hediet.vscode-drawio

Copy link
Member

@seebi seebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only approved due to the urgency.

@seebi seebi merged commit 99a2989 into main Jul 6, 2023
2 checks passed
@seebi seebi deleted the feature/ECC-5069-link-ids-event-to-kg branch July 6, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants