Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/evaluate template tutorial ECC-5660 #142

Merged
merged 21 commits into from
Aug 7, 2023

Conversation

rpietzsch
Copy link
Contributor

No description provided.

@rpietzsch rpietzsch changed the title Feature/evaluate template tutorial ecc 5660 Feature/evaluate template tutorial ECC-5660 Aug 7, 2023
Copy link
Contributor

@irangareddy irangareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly make these changes @rpietzsch

Comment on lines 55 to 56
!!! info
The vocabulary contains the classes and properties needed to map the source data into entities in the Knowledge Graph.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +361 to +363
!!! info

After the workflow has finished you can find an email in the mailbox of the recipient address you specified for the **Send eMail** task.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +351 to +353
!!! info

The **Transform** sends the *message* parameter with our message text as its value to the **Send eMail** task.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +268 to +270
!!! info

The **RDF** dataset holds an NTriples file that contains the triples requested by the **Request RDF triples** task, which we will send as the email attachment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +252 to +254
!!! info

The **Request RDF triples** task is used to write all tripled from the company graph into an RDF dataset in NTriples serialization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +202 to +204
!!! info

The text dataset holds a text file that will contain the evaluated Jinja template that will be our email message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +196 to +198
!!! note

The variable names correspond to those in the SPARQL query we previously created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines 167 to 168
!!! Info
The Jinja template in this item acts as the template for our email message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +119 to +122
!!! info

The SPARQL select query is used to retrieve the data from the company graph that we want to include in our email.
It counts the instances of employees, managers, departments, products, and products that have other compatible products in the database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

Comment on lines +100 to +102
!!! info

The **Knowledge graph** dataset holds the **Company graph** we uploaded earlier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of information should be inline instead of under the title.

@rpietzsch
Copy link
Contributor Author

@irangareddy, inline [end] makes the style (width) of the images inconsistent. In section with an inline admonition images use less width, in others they use more. This seams odd ... thus I'd prefer to keep it the "original" way.

Copy link
Contributor

@irangareddy irangareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged

@irangareddy irangareddy merged commit b75d054 into main Aug 7, 2023
2 checks passed
@irangareddy irangareddy deleted the feature/evaluateTemplateTutorial-ECC-5660 branch August 7, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants