Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a session is retired, make sure to also clear access token #1105

Merged
merged 2 commits into from
Aug 9, 2022
Merged

When a session is retired, make sure to also clear access token #1105

merged 2 commits into from
Aug 9, 2022

Conversation

ecederstrand
Copy link
Owner

Fixes #1090

@ecederstrand ecederstrand mentioned this pull request Aug 8, 2022
Closed
@coveralls
Copy link

coveralls commented Aug 8, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 92.79% when pulling eb59c9d on 1090-fix-token-refresh-2 into 5b6656d on master.

@cmin764
Copy link

cmin764 commented Aug 9, 2022 •
edited
Loading

This alone indeed fixes the problem, I just tested with our Robocorp portal example (without our monkey patch) and it works.

This was the real fix: #1104

@ecederstrand ecederstrand merged commit f73143c into master Aug 9, 2022
@ecederstrand ecederstrand deleted the 1090-fix-token-refresh-2 branch August 9, 2022 08:00
@ecederstrand ecederstrand mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expired OAuth token refreshing endless loop
3 participants
@ecederstrand @coveralls @cmin764