Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Commit

Permalink
Merge pull request #1551 from ecency/bugfix/emoji-picker-in-editor
Browse files Browse the repository at this point in the history
Fixed emoji picker, migrated editor toolbar to functional component
  • Loading branch information
feruzm authored Feb 14, 2024
2 parents 321ce2d + 9d14e0d commit 5586b25
Show file tree
Hide file tree
Showing 6 changed files with 441 additions and 564 deletions.
36 changes: 34 additions & 2 deletions src/common/components/comment/__snapshots__/index.spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,26 @@ exports[`(1) Default render 1`] = `
fill="currentColor"
/>
</svg>
<div
className="sub-tool-menu"
>
<div
className="sub-tool-menu-item"
onClick={[Function]}
>
Upload
</div>
<div
className="sub-tool-menu-item"
onClick={[Function]}
>
Gallery
</div>
</div>
</div>
<div
className="editor-tool"
id="editor-tool-emoji-picker-525d9194-2e44-4e7a-9e86-ef2e448c455a"
id="editor-tool-emoji-picker-819cbf44-a32a-4077-a426-e918846a334c"
role="none"
title="Emoji"
>
Expand Down Expand Up @@ -549,10 +565,26 @@ exports[`(2) Cancellable, in progress 1`] = `
fill="currentColor"
/>
</svg>
<div
className="sub-tool-menu"
>
<div
className="sub-tool-menu-item"
onClick={[Function]}
>
Upload
</div>
<div
className="sub-tool-menu-item"
onClick={[Function]}
>
Gallery
</div>
</div>
</div>
<div
className="editor-tool"
id="editor-tool-emoji-picker-1dfb459c-12aa-465e-b119-bf96521d112c"
id="editor-tool-emoji-picker-2baa82a6-c21a-4fe6-b80f-3c6b2a6a0b20"
role="none"
title="Emoji"
>
Expand Down
9 changes: 4 additions & 5 deletions src/common/components/comment/index.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import React from "react";

import Comment from "./index";

import { UiInstance, globalInstance, entryInstance1 } from "../../helper/test-helper";

import renderer from "react-test-renderer";
import { entryInstance1, globalInstance, UiInstance } from "../../helper/test-helper";

import emojiData from "../../../../public/emoji.json";
import { withStore } from "../../tests/with-store";

jest.mock("../../api/misc", () => ({
getEmojiData: () =>
Expand Down Expand Up @@ -41,13 +40,13 @@ const defProps = {
it("(1) Default render", () => {
const props = { ...defProps };

const component = renderer.create(<Comment {...props} />);
const component = withStore(<Comment {...props} />);
expect(component.toJSON()).toMatchSnapshot();
});

it("(2) Cancellable, in progress", () => {
const props = { ...{ inProgress: true, cancellable: true, defText: "foo" }, ...defProps };

const component = renderer.create(<Comment {...props} />);
const component = withStore(<Comment {...props} />);
expect(component.toJSON()).toMatchSnapshot();
});
4 changes: 2 additions & 2 deletions src/common/components/comment/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ActiveUser } from "../../store/active-user/types";
import { Account } from "../../store/accounts/types";
import { ToggleType, UI } from "../../store/ui/types";
import { Entry } from "../../store/entries/types";
import EditorToolbar, { detectEvent, toolbarEventListener } from "../editor-toolbar";
import { detectEvent, EditorToolbar, toolbarEventListener } from "../editor-toolbar";
import LoginRequired from "../login-required";
import defaults from "../../constants/defaults.json";
import { renderPostBody, setProxyBase } from "@ecency/render-helper";
Expand Down Expand Up @@ -238,7 +238,7 @@ export class Comment extends Component<Props, State> {
!showEmoji && !showGif && this.setState({ showEmoji: true, showGif: true })
}
>
{EditorToolbar({ ...this.props, sm: true, showEmoji, comment: true })}
<EditorToolbar comment={true} {...this.props} sm={true} />
<div className="comment-body" onKeyDown={this.handleShortcuts} ref={this.commentBodyRef}>
<TextareaAutocomplete
className={`the-editor accepts-emoji ${text?.length > 20 ? "expanded" : ""}`}
Expand Down
Loading

0 comments on commit 5586b25

Please sign in to comment.