remove unnecessary todos

eclipse-aas4j · Oct 27, 2023 · 7e64d11 · 7e64d11
1 parent a7fd2b0
commit 7e64d11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...t-json/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/json/JsonSerializer.java b/...t-json/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/json/JsonSerializer.java
@@ -68,7 +68,6 @@ protected void buildMapper() {
 
     protected SimpleModule buildCustomSerializerModule() {
         SimpleModule module = new SimpleModule();
-        // TODO: module.addSerializer(EmbeddedDataSpecification.class, new EmbeddedDataSpecificationSerializer());
         return module;
     }
 

diff --git a/...-xml/src/test/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/xml/XmlSerializerTest.java b/...-xml/src/test/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/xml/XmlSerializerTest.java
@@ -219,8 +219,8 @@ private String removeDefaults(String aasXml) {
         aasXml = aasXml.replace("<test:kind>Instance</test:kind>", "");
         aasXml = aasXml.replace("<aas:category>VARIABLE</aas:category>", "");
         aasXml = aasXml.replace("<test:category>VARIABLE</test:category>", "");
-        aasXml = aasXml.replace("<aas:category>PROPERTY</aas:category>", ""); // TODO: only for ConceptDescriptions
-        aasXml = aasXml.replace("<test:category>PROPERTY</test:category>", ""); // TODO: only for ConceptDescriptions
+        aasXml = aasXml.replace("<aas:category>PROPERTY</aas:category>", "");
+        aasXml = aasXml.replace("<test:category>PROPERTY</test:category>", "");
         aasXml = aasXml.replace("<aas:kind>ConceptQualifier</aas:kind>", "");
         aasXml = aasXml.replace("<test:kind>ConceptQualifier</test:kind>", "");
         aasXml = aasXml.replace("<aas:orderRelevant>true</aas:orderRelevant>", "");
@@ -243,7 +243,7 @@ private boolean ignoreDefaults(Node node) {
 
         if (node.getLocalName() != null 
                 && node.getLocalName().equals("category") 
-                && node.getFirstChild().getNodeValue().equals("PROPERTY")) { // TODO: only for ConceptDescriptions
+                && node.getFirstChild().getNodeValue().equals("PROPERTY")) {
             return false;
         }