Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add <relativePath> to pom.xml #190

Closed
wants to merge 6 commits into from
Closed

Conversation

in-fke
Copy link

@in-fke in-fke commented Oct 31, 2023

No description provided.

@FrankSchnicke
Copy link
Contributor

Thank you very much for your contribution! From my understanding, the default behavior of parent pom resolution of Maven is checking the parent directory - thus, explicitly setting the relative path to the parent directory should not change anything. What is the motivation of explicitly setting the relative path here in this way?

As of now, the PR includes lots of changes on ".gitignore" as well as adding ".classpath" and ".project" files of an IDE. Is this intentional? If no, would it be possible to remove the files & changes not related to relative path in the POMs?

@in-fke
Copy link
Author

in-fke commented Nov 8, 2023

sorry, the .classpath and .project where NOT intended to be included - let me get back to reviewing this.

From my understanding, the default behavior of parent pom resolution of Maven is checking the parent directory - thus, explicitly setting the relative path to the parent directory should not change anything

And here you are also correct, so this whole PR might as well be dropped, sorry, for the confusion.
It was probably the eclipse:eclipse goal that had trouble resolving the parent pom but that is specific to this plugin.
I have yet to learn on how to work with gitub PRs, so please bear with me.

As said, might as well drop this PR....

@FrankSchnicke
Copy link
Contributor

Thanks for the quick response - as suggested by you, I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants