-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlassFish support #282
GlassFish support #282
Conversation
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Conflicts: pom.xml Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Use GlassFish Embedded container. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Some XML parsers like Xerces don't follow the HTTP to HTTPS redirect. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
These look like a reasonable set of changes I could move forward to merge. What is causing the draft status? Are the changes ready for me to test or is there some other work left to finalize the PR? |
I raised the PR in draft because I prefer to merge #273 because of the reasons stated in the description. But since you suggested to use this PR instead, I'll remove the draft status now and close #273 |
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
I'll look to test and merge this. There may be some delay as I am currently on vacation. Hopefully there is no hurry? |
There's no hurry at all. Take your time and enjoy your vacation! |
I've briefly tested this and it looks fine. @ojuschugh1 will also give it a spin. Then it can be merged. |
@m-reza-rahman I have tested it via command line and vs code(debugged and tested) for Glassfish and Payara. It is working fine. I have tested the batch job as well, it is also working properly. A total of 29/29 test cases passed without any error. |
Great. I’ll merge this as soon I have bandwidth to update all the associated documentation on the wiki and website. |
An alternative to #273 with a connector from the Arquillian project.
However, there are a few drawbacks:
dependency
Maven plugin.1.0.0.Alpha1
and it's still not stable and safe to usejersey-hk2
(3.0.0-M4), which depends on an artifact, which isn't in Maven Central (hk2-locator
version3.0.0-M1
). I added an explicit dependency onjersey-hk2
version3.1.3
to fix the buildarquillian-glassfish-managed-6
toarquillian-glassfish-managed-jakarta
, although the latter hasn't been released to Maven Central yet: https://github.com/arquillian/arquillian-container-glassfish6/blob/master/glassfish-managed/pom.xml#L12