Switch from o.e.osgi.services to org.osgi.service.component.annotations #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from o.e.osgi.services to org.osgi.service.component.annotations
ruspl-afed
force-pushed
the
osgi_component
branch
from
7335389
to
948d8d8
Compare
jonahgraham
approved these changes
Jun 27, 2024
|
Does this change affect compatibility with older Eclipses? The plug-ins are expected to run on 2020-09 and higher. |
|
I did my best to preserve compatibility with 2020-09. In my understanding this annotation is needed for compile time only. For runtime component xml manifest matters, and it has no changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for Equinox change eclipse-equinox/equinox#402
Fixes #609