From 2291f9fda2ce5419851cb38c21a7194af7fa479f Mon Sep 17 00:00:00 2001
From: Thomas Watson <tjwatson@us.ibm.com>
Date: Mon, 13 Jan 2025 14:39:05 -0600
Subject: [PATCH] Remove internal usage of Equinox Framework Debug class

These trace messages are not particularly useful and
I would like to remove this general debug flag from the
framework.

If trace is needed in transforms we should have a separate
option for it.
---
 .../internal/transforms/TransformedBundleFile.java   | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/bundles/org.eclipse.equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/TransformedBundleFile.java b/bundles/org.eclipse.equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/TransformedBundleFile.java
index 4a04b6d6d4a..33d69a5f08f 100644
--- a/bundles/org.eclipse.equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/TransformedBundleFile.java
+++ b/bundles/org.eclipse.equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/TransformedBundleFile.java
@@ -20,7 +20,6 @@
 import java.util.regex.Pattern;
 import org.eclipse.equinox.internal.transforms.LazyInputStream.InputStreamProvider;
 import org.eclipse.osgi.framework.log.FrameworkLogEntry;
-import org.eclipse.osgi.internal.debug.Debug;
 import org.eclipse.osgi.internal.framework.EquinoxContainer;
 import org.eclipse.osgi.storage.BundleInfo.Generation;
 import org.eclipse.osgi.storage.StorageUtil;
@@ -38,7 +37,6 @@ public class TransformedBundleFile extends BundleFileWrapper {
 	private final TransformerHook transformerHook;
 	private final BundleFile delegate;
 	private final Generation generation;
-	private final Debug debug;
 
 	/**
 	 * Create a wrapped bundle file. Requests into this file will be compared to the
@@ -54,7 +52,6 @@ public TransformedBundleFile(TransformerHook transformerHook, Generation generat
 		this.transformerHook = transformerHook;
 		this.generation = generation;
 		this.delegate = delegate;
-		this.debug = generation.getBundleInfo().getStorage().getConfiguration().getDebug();
 	}
 
 	Generation getGeneration() {
@@ -148,9 +145,6 @@ public File getFile(String path, boolean nativeCode) {
 			File nested = getExtractFile(path);
 			if (nested != null) {
 				if (nested.exists()) {
-					/* the entry is already cached */
-					if (debug.DEBUG_GENERAL)
-						Debug.println("File already present: " + nested.getPath()); //$NON-NLS-1$
 					if (nested.isDirectory())
 						// must ensure the complete directory is extracted (bug
 						// 182585)
@@ -165,10 +159,7 @@ public File getFile(String path, boolean nativeCode) {
 						InputStream in = getEntry(path).getInputStream();
 						if (in == null)
 							return null;
-						// if (in instanceof )
 						/* the entry has not been cached */
-						if (debug.DEBUG_GENERAL)
-							Debug.println("Creating file: " + nested.getPath()); //$NON-NLS-1$
 						/* create the necessary directories */
 						File dir = new File(nested.getParent());
 						if (!dir.exists() && !dir.mkdirs()) {
@@ -185,8 +176,7 @@ public File getFile(String path, boolean nativeCode) {
 				return nested;
 			}
 		} catch (IOException e) {
-			if (debug.DEBUG_GENERAL)
-				Debug.printStackTrace(e);
+			// consider logging
 		}
 		return null;
 	}