bugfix: SAMM-CLI aas generation: aas:Operation lacks semanticId #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Add semanticId generation for Operation; - Add ConceptDescription generation for Operation. Fixes eclipse-esmf#458
|
Looks good. One more request, can you add a unit test to https://github.com/eclipse-esmf/esmf-sdk/blob/main/core/esmf-aspect-model-aas-generator/src/test/java/org/eclipse/esmf/aspectmodel/aas/AspectModelAASGeneratorTest.java ? |
…tests Changes: - Add test. Fixes eclipse-esmf#458
…tests Changes: - Add test; - Small refactoring of others tests. Fixes eclipse-esmf#458
KobOp
approved these changes
Dec 15, 2023
atextor
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #458