Fix: Regressions caused by cleaning up BreakCycle & PopulateRanks #246
Conversation
|
I just went over the changes from #234 again and in the future, those should really be separated into separate pull requests, simply because of how distracting some of the changes are...
If all of those were separated, I think it'd have been much easier to figure out what went wrong. Just some food for thought 😅 |
The for-each loop inside the BreakCycle method used to iterate over all graph nodes. This was wrongfully changed to a local variable which is initialized as an empty list. The for-each loop inside PopulateRanks iterates over all graph nodes and calls VirtualNodeCreation internally. The constructor of this class, however, may add nodes to the graph, leading to a ConcurrentModifcationException. To avoid this problem, we iterate of a local copy of the graph nodes instead. Amends 31a7012
@ptziegler I think you are totally right. My naive attempt of thinking to clean-up files that are touched automatically does not seem to work. At least for the Override annotation I found a better solution: I used a project wide clean-up feature from Eclipse IDE: PR #241. But for others I'm not yet sure. Happy for any ideas. |
|
@ptziegler thx for the fast reaction, the fix, and a test for it! |
The for-each loop inside the BreakCycle method used to iterate over all graph nodes. This was wrongfully changed to a local variable which is initialized as an empty list.
The for-each loop inside PopulateRanks iterates over all graph nodes and calls VirtualNodeCreation internally. The constructor of this class, however, may add nodes to the graph, leading to a
ConcurrentModifcationException. To avoid this problem, we iterate of a local copy of the graph nodes instead.
Amends 31a7012