Typify internal list in DirectGraphLayout and convert to Deque #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switching to a Deque should be safe, given that this field is package-private. |
ptziegler
force-pushed
the
typify-directed-graph-layout
branch
2 times, most recently
from
49e17f7 to
15d96e9
Compare
By using a deque, we have access to both an iterator() and an descendingIterator() method. This allows us to iterate over the collection in both directions.
ptziegler
force-pushed
the
typify-directed-graph-layout
branch
from
15d96e9 to
620ccf3
Compare
azoitl
reviewed
Aug 19, 2023
...lipse.zest.layouts/src/org/eclipse/zest/layouts/algorithms/DirectedGraphLayoutAlgorithm.java
Show resolved
Hide resolved
|
@ptziegler have you seen my latest comment? It would be great if we could merge that commit somewhere today or early tomorrow as we have M3 deadline. |
My apologies. No clue why I don't get notified by this pull request... I've just responded to your comment. |
|
No problem. Thanks for the feedback. Will merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a deque, we have access to both an iterator() and an descendingIterator() method. This allows us to iterate over the collection in both directions.