[Zest 2.0] Ignore node size when calculating position in layout #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this while migrating the Zest layout example. This is what the layout currently looks like:
Even though it's supposed to look like:
|
The location of a node describes its top-left pixel, rather than its center. When using layout algorithms that are based on the grid layout, this causes the offset to be half the space between the rows and columns plus the half the width and height of the nodes. Latter is undesirable and may cause nodes to be partially moved outside the client area. The same issue can be observed in the other layout algorithms (Spring/Tree/Radial) when fitting the nodes into the client area, because the same mistake is repeated in the AlgorithmHelper class.
ptziegler
force-pushed
the
zest-grid-location
branch
from
9446d81
to
5b880be
Compare
ptziegler
changed the title
azoitl
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location of a node describes its top-left pixel, rather than its center. When using layout algorithms that are based on the grid layout, this causes the offset to be half the space between the rows and columns plus the half the width and height of the nodes.
Latter is undesirable and may cause nodes to be partially moved outside the client area.
The same issue can be observed in the other layout algorithms (Spring/Tree/Radial) when fitting the nodes into the client area, because the same mistake is repeated in the AlgorithmHelper class.