Modifications done inside the bodyDeclaration and the issue has fixed.

eclipse-jdt · Oct 13, 2024 · 16aa3b9 · 16aa3b9
1 parent 4e9610d
commit 16aa3b9
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/.../src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingRecordDeclarationTest.java b/.../src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingRecordDeclarationTest.java
@@ -1408,14 +1408,15 @@ public void testRecord_029() throws Exception {
 		}
 		IPackageFragment pack1= this.sourceFolder.createPackageFragment("test1", false, null);
 
-		StringBuilder buf= new StringBuilder();
-		buf.append("package test1;\n");
-		buf.append("record Test(String name) {\n");
-		buf.append("	public static Builder builder() {}\n");
-		buf.append("	public static final class Builder {}\n");
-		buf.append("}\n");
+		String code = """
+					package test1;
+					public record Test(String name) {
+					    public static Builder builder() {}
+					    public static final class Builder {}
+					}
+				""";
 
-		ICompilationUnit cu= pack1.createCompilationUnit("Test.java", buf.toString(), false, null);
+		ICompilationUnit cu= pack1.createCompilationUnit("Test.java", code, false, null);
 
 		CompilationUnit astRoot= createAST(cu);
 		ASTRewrite rewrite= ASTRewrite.create(astRoot.getAST());
@@ -1429,14 +1430,14 @@ public void testRecord_029() throws Exception {
 
 		String preview= evaluateRewrite(cu, rewrite);
 
-		buf = new StringBuilder();
-		buf.append("package test1;\n");
-		buf.append("record Test(String name) {\n");
-		buf.append("	\n");
-		buf.append("	public static final class Builder {}\n");
-		buf.append("}\n");
+		String reWriteCode = """
+					package test1;
+					public record Test(String name) {
+					    public static final class Builder {}
+					}
+				""";
 
-		assertEqualString(preview, buf.toString());
+		assertEqualString(preview, reWriteCode);
 	}
 
 }

diff --git a/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTConverter.java b/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTConverter.java
@@ -315,6 +315,7 @@ protected void buildBodyDeclarations(
 
 			  } else {
 				  methodsIndex++;
+				  continue;
 			  }
 
 			}

diff --git a/org.eclipse.jdt.core/dom/org/eclipse/jdt/internal/core/dom/rewrite/ASTRewriteAnalyzer.java b/org.eclipse.jdt.core/dom/org/eclipse/jdt/internal/core/dom/rewrite/ASTRewriteAnalyzer.java
@@ -393,7 +393,7 @@ final void addEditGroup(TextEditGroup editGroup, TextEdit edit) {
 	}
 
 	final TextEdit doTextRemove(int offset, int len, TextEditGroup editGroup) {
-		if (len <= 0) {
+		if (len == 0) {
 			return null;
 		}
 		TextEdit edit= new DeleteEdit(offset, len);