added more unit tests

eclipse-jdt · Oct 14, 2024 · 6298d93 · 6298d93
1 parent 237d983
commit 6298d93
Show file tree

Hide file tree

Showing 2 changed files with 93 additions and 4 deletions.
diff --git a/.../src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingRecordDeclarationTest.java b/.../src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingRecordDeclarationTest.java
@@ -1402,15 +1402,15 @@ public void testRecord_028() throws Exception {
 
 	}
 
-	public void testRecord_029() throws Exception {
+	public void testRecord_029_a() throws Exception {
 		if (checkAPILevel()) {
 			return;
 		}
 		IPackageFragment pack1= this.sourceFolder.createPackageFragment("test1", false, null);
 
 		String code = """
 					package test1;
-					public record Test(String name) {
+					record Test(String name) {
 					    public static Builder builder() {}
 					    public static final class Builder {}
 					}
@@ -1432,13 +1432,102 @@ public static final class Builder {}
 
 		String reWriteCode = """
 					package test1;
-					public record Test(String name) {
+					record Test(String name) {
 					    public static final class Builder {}
 					}
 				""";
 
 		assertEqualString(preview, reWriteCode);
 	}
 
+	public void testRecord_029_b() throws Exception {
+		if (checkAPILevel()) {
+			return;
+		}
+		IPackageFragment pack1= this.sourceFolder.createPackageFragment("test1", false, null);
+
+		String code = """
+					package test1;
+					public class Test {
+					    public static Builder builder() {}
+					    public static final class Builder {}
+					}
+				""";
+
+		ICompilationUnit cu= pack1.createCompilationUnit("Test.java", code, false, null);
+
+		CompilationUnit astRoot= createAST(cu);
+		ASTRewrite rewrite= ASTRewrite.create(astRoot.getAST());
+
+		assertTrue("Parse errors", (astRoot.getFlags() & ASTNode.MALFORMED) == 0);
+		List <TypeDeclaration> methods= astRoot.types();
+		MethodDeclaration methodDecl= findMethodDeclaration(methods.get(0), "builder");
+		{
+			rewrite.remove(methodDecl, null);
+		}
+
+		String preview= evaluateRewrite(cu, rewrite);
+
+		String reWriteCode = """
+					package test1;
+					public class Test {
+					    public static final class Builder {}
+					}
+				""";
+
+		assertEqualString(preview, reWriteCode);
+	}
+
+	public void testRecord_029_c() throws Exception {
+		if (checkAPILevel()) {
+			return;
+		}
+		IPackageFragment pack1= this.sourceFolder.createPackageFragment("test1", false, null);
+
+		String code = """
+					package test1;
+					record Test(String name) {
+					    public static Builder builder() {}
+					    public static final class Builder {}
+					    public static Builder builderNew() {}
+					    public static final class builderNew {
+					    	builderNew(){
+					    		System.out.println("Test");
+					    	}
+					    }
+					}
+				""";
+
+		ICompilationUnit cu= pack1.createCompilationUnit("Test.java", code, false, null);
+
+		CompilationUnit astRoot= createAST(cu);
+		ASTRewrite rewrite= ASTRewrite.create(astRoot.getAST());
+
+		assertTrue("Parse errors", (astRoot.getFlags() & ASTNode.MALFORMED) == 0);
+		List <RecordDeclaration> methods= astRoot.types();
+		MethodDeclaration methodDecl= findMethodDeclaration(methods.get(0), "builder");
+		MethodDeclaration methodDeclNew= findMethodDeclaration(methods.get(0), "builderNew");
+		{
+			rewrite.remove(methodDecl, null);
+			rewrite.remove(methodDeclNew, null);
+		}
+
+		String preview= evaluateRewrite(cu, rewrite);
+
+		String reWriteCode = """
+					package test1;
+					record Test(String name) {
+					    public static final class Builder {}
+					    public static final class builderNew {
+					    	builderNew(){
+					    		System.out.println("Test");
+					    	}
+					    }
+					}
+				""";
+
+		assertEqualString(preview, reWriteCode);
+	}
+
 }
 
diff --git a/org.eclipse.jdt.core/model/org/eclipse/jdt/core/JavaCore.java b/org.eclipse.jdt.core/model/org/eclipse/jdt/core/JavaCore.java
@@ -3350,7 +3350,7 @@ public static boolean isSupportedJavaVersion(String version) {
 	 *
 	 * @return {@code true} if the given string represents Java language version is fully supported by Eclipse compiler
 	 * @see #getAllJavaSourceVersionsSupportedByCompiler()
-	 * @since 3.40
+	 * @since 3.39
 	 */
 	public static boolean isJavaSourceVersionSupportedByCompiler(String version) {
 		if(version == null || version.isBlank()) {