-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Remove duplicated configuration of tycho-p2-extras-plugin #2994
[Build] Remove duplicated configuration of tycho-p2-extras-plugin #2994
Conversation
6837e7f
to
d87fb8e
Compare
I am not an expert on this, so i have a basic question: Where is it configured that JDT uses eclipse-platform-parent? |
https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/pom.xml#L15 |
Can we hold this off? I'm about to work on an enhancement for this. |
d87fb8e
to
2ab7a15
Compare
Now it is ready, but requires eclipse-platform/eclipse.platform.releng.aggregator#2381 to succeed. |
2ab7a15
to
a580694
Compare
@akurtakov thanks for the update. The test-failure looks unrelated to me. |
Most parts of the configuration are already inherited from the 'eclipse-platform-parent'. And leverage the new overwritable property to permanently disable the baseline check, which is introduced in eclipse-platform/eclipse.platform.releng.aggregator#2381
a580694
to
ae1d26b
Compare
What it does
Remove duplicated configuration of tycho-p2-extras-plugin. Most parts of the configuration are already inherited from the
eclipse-platform-parent
:https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/73b7934ea89cbf0a8b0235572c8e80e84aed0104/eclipse-platform-parent/pom.xml#L372-L388
This would also help in the future in case JDT wants to use the workflow for automated version increments in pull-requests:
Also leverage the new overwritable property to permanently disable the baseline check, which is introduced in
@akurtakov, @iloveeclipse or @jukzi could you please have a look at this?
Author checklist