Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tests include org.eclipse.jdt.annotation_v1 rather than declaring a dependency #3072

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

stephan-herrmann
Copy link
Contributor

  • access annotation_v1 from a local copy (jar)
  • can no longer use compliance to switch annotation jars since version 1.7- are no longer supported
  • revive capability to tests with declaration annotations via new class NullDeclarationAnnotationTest
    • pull up helpers from ResourceLeakAnnotatedTests which allow running inherited tests.

Fixes #3029

dependency

+ access annotation_v1 from a local copy (jar)
+ can no longer use compliance to switch annotation jars since
  version 1.7- are no longer supported
+ revive capability to tests with declaration annotations via new
  class NullDeclarationAnnotationTest
  - pull up helpers from ResourceLeakAnnotatedTests which allow running
    inherited tests.

Fixes eclipse-jdt#3029
@stephan-herrmann stephan-herrmann added this to the 4.34 M2 milestone Oct 11, 2024
@stephan-herrmann
Copy link
Contributor Author

Other locations still referencing the 1.x library:

  • org.eclipse.jdt.apt.pluggable.tests : MANIFEST.MF (to be handled by this PR)
  • org.eclipse.jdt.ui.tests: MANIFEST.MF
  • the JDT feature

@stephan-herrmann
Copy link
Contributor Author

org.eclipse.jdt.apt.pluggable.tests : MANIFEST.MF (to be handled by this PR)

Added for bug 441983, but apparently there isn't even a need for these dependencies.

@stephan-herrmann stephan-herrmann merged commit 0037ab1 into eclipse-jdt:master Oct 13, 2024
10 checks passed
@stephan-herrmann stephan-herrmann deleted the issue3029 branch October 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let tests include org.eclipse.jdt.annotation_v1 rather than declaring a dependency
1 participant