-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Tokens ext point #1683
base: master
Are you sure you want to change the base?
Semantic Tokens ext point #1683
Conversation
3e87ca0
to
9332408
Compare
After the initial discussion in #1594, this is the corresponding PR with the implementation. Would be extremely awesome if someone could have a look and provide feedback, so that we can get this merged whenever it makes sense. Interested @noopur2507, @iloveeclipse, @HannesWell ? |
Unfortunately I'm not a JDT committer and cannot say with certainty who would be the best person to review this. |
I'm not a committer on JDT either ( https://projects.eclipse.org/projects/eclipse.jdt/elections/election-mickael-istria-committer-eclipse-jdt-java-development-tools ). I've put some generic comments about documentation and API that needs to be polished. |
<meta.schema plugin="org.eclipse.jdt.ui" id="semanticTokens" name="%semanticTokens"/> | ||
</appInfo> | ||
<documentation> | ||
[Enter description of this extension point.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be filled
|
||
import org.eclipse.jdt.core.dom.CompilationUnit; | ||
|
||
public interface SemanticTokensProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ISemanticTokensProvider
for consistency with other interfaces
@mickaelistria @martinlippert updated the PR for Mickael's comments |
@BoykoAlex Thanks for incorporating the comments from @mickaelistria (and thanks a lot @mickaelistria for taking a look, much appreciated). Now looking for a JDT UI committer to pick this up and provide feedback, merge, or whatever makes sense to move this forward. |
Fixes #1594
Extension point to contribute semantic tokens into the JDT Java editor.