Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisitorTest failing since I20241015-1820 #1722

Closed
noopur2507 opened this issue Oct 17, 2024 · 2 comments · Fixed by eclipse-jdt/eclipse.jdt.core#3108
Closed

VisitorTest failing since I20241015-1820 #1722

noopur2507 opened this issue Oct 17, 2024 · 2 comments · Fixed by eclipse-jdt/eclipse.jdt.core#3108
Assignees
@stephan-herrmann

Comments

@noopur2507
Copy link
Member

org.eclipse.jdt.internal.common.VisitorTest is failing in I-builds since I20241015-1820.

https://download.eclipse.org/eclipse/downloads/drops4/I20241016-2000/testresults/html/org.eclipse.jdt.ui.tests_ep434I-unit-macM1-java17_macosx.cocoa.aarch64_17.html

VisitorTest

Missing system library

java.lang.IllegalStateException: Missing system library
at org.eclipse.jdt.core.dom.ASTParser.checkForSystemLibrary(ASTParser.java:311)
at org.eclipse.jdt.core.dom.ASTParser.getClasspath(ASTParser.java:272)
at org.eclipse.jdt.core.dom.ASTParser.internalCreateASTCached(ASTParser.java:1299)
at org.eclipse.jdt.core.dom.ASTParser.lambda$1(ASTParser.java:1178)
at org.eclipse.jdt.internal.core.JavaModelManager.cacheZipFiles(JavaModelManager.java:5692)
at org.eclipse.jdt.core.dom.ASTParser.internalCreateAST(ASTParser.java:1178)
at org.eclipse.jdt.core.dom.ASTParser.createAST(ASTParser.java:918)
at org.eclipse.jdt.internal.common.VisitorTest.init(VisitorTest.java:81)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
@noopur2507
Copy link
Member Author

noopur2507 commented Oct 17, 2024 •
edited
Loading

Reverting JDT/Core commit 74d062b38d3003638127127cc5358dd9f79df0f4 from eclipse-jdt/eclipse.jdt.core#3047 is turning the test green.

This was referenced Oct 17, 2024
Closed
Open
@stephan-herrmann stephan-herrmann self-assigned this Oct 17, 2024
@stephan-herrmann
Copy link
Contributor

Thanks, @noopur2507 , I'll take a look.

stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Oct 17, 2024
@stephan-herrmann
+ Ensure ClasspathJrt initialized to fix eclipse-jdt/eclipse.jdt.ui#1722
e8fc652 


+ Fix test's getJCL15PlusLibraryIfNeeded()
@stephan-herrmann stephan-herrmann mentioned this issue Oct 17, 2024
Merged
stephan-herrmann added a commit to eclipse-jdt/eclipse.jdt.core that referenced this issue Oct 17, 2024
@stephan-herrmann
+ Ensure ClasspathJrt initialized to fix eclipse-jdt/eclipse.jdt.ui#1722
3e287dc 
 (#3108)

+ Fix test's getJCL15PlusLibraryIfNeeded()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephan-herrmann stephan-herrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix classpath issues in ClasspathJrt and model tests stephan-herrmann/eclipse.jdt.core
2 participants
@noopur2507 @stephan-herrmann