-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Filter from call Hierarchy #1730
Draft
jannisCode
wants to merge
1
commit into
eclipse-jdt:master
Choose a base branch
from
jannisCode:Refactoring_CallHierarchy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactoring Filter from call Hierarchy #1730
jannisCode
wants to merge
1
commit into
eclipse-jdt:master
from
jannisCode:Refactoring_CallHierarchy
+101
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 22, 2024 10:43
6f320a6
to
b598a1b
Compare
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 22, 2024 14:02
b598a1b
to
138e939
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 23, 2024
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 23, 2024 09:41
138e939
to
12a4eb0
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 07:54
12a4eb0
to
1d16fb4
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 11:18
1d16fb4
to
05762ad
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 12:21
05762ad
to
de3e1dc
Compare
I used your feedback and used Enums istead of arrays in the latest commit! Everything else is still the same! |
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 12:23
de3e1dc
to
381b6cd
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 12:26
381b6cd
to
405eaa4
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 12:27
405eaa4
to
cc0b1e8
Compare
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
October 25, 2024 12:28
cc0b1e8
to
b89f05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR is a refactoring of the code for the filters in the Call Hierarchy.
It makes the code more modifiable and versatile
Author checklist