Refactoring Filter from call Hierarchy #1730
Draft
+101
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
6f320a6
to
b598a1b
Compare
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
b598a1b
to
138e939
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 23, 2024
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
138e939
to
12a4eb0
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
12a4eb0
to
1d16fb4
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
1d16fb4
to
05762ad
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
05762ad
to
de3e1dc
Compare
|
I used your feedback and used Enums istead of arrays in the latest commit! Everything else is still the same! |
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
de3e1dc
to
381b6cd
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
381b6cd
to
405eaa4
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 25, 2024
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
405eaa4
to
cc0b1e8
Compare
Now it works with an enum rather than an array which is much nicer eclipse-jdt#1730
jannisCode
force-pushed
the
Refactoring_CallHierarchy
branch
from
cc0b1e8
to
b89f05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR is a refactoring of the code for the filters in the Call Hierarchy.
It makes the code more modifiable and versatile
Author checklist