Do not expand same class twice in (quick) type hierarchy #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The compilation fails because eclipse-platform/eclipse.platform.ui#2692 is not merged |
fedejeanne
force-pushed
the
slow_type_hierarchy
branch
from
d5cba4c to
ff7af37
Compare
fedejeanne
force-pushed
the
slow_type_hierarchy
branch
from
ff7af37 to
74db219
Compare
jukzi
reviewed
Jan 15, 2025
| @@ -137,6 +137,14 @@ | |||
| </message_arguments> | |||
| </filter> | |||
| </resource> | |||
| <resource path="ui/org/eclipse/jdt/internal/ui/typehierarchy/HierarchyInformationControl.java" type="org.eclipse.jdt.internal.ui.typehierarchy.HierarchyInformationControl"> | |||
There was a problem hiding this comment.
Yes, because of the (anonymous) subclass of TreeViewer in HierarchyInformationControl
fedejeanne
force-pushed
the
slow_type_hierarchy
branch
from
74db219 to
221a17f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #1830
Requires
How to test
Expand an interface from here:
The (Quick) Type Hierarchy should not expand the same interface twice
Author checklist