Semantic Tokens ext point #1683
Conversation
BoykoAlex
force-pushed
the
sync-jdt-syntax-highlighting
branch
from
3e87ca0
to
9332408
Compare
|
After the initial discussion in #1594, this is the corresponding PR with the implementation. Would be extremely awesome if someone could have a look and provide feedback, so that we can get this merged whenever it makes sense. Interested @noopur2507, @iloveeclipse, @HannesWell ? |
Unfortunately I'm not a JDT committer and cannot say with certainty who would be the best person to review this. |
|
I'm not a committer on JDT either ( https://projects.eclipse.org/projects/eclipse.jdt/elections/election-mickael-istria-committer-eclipse-jdt-java-development-tools ). I've put some generic comments about documentation and API that needs to be polished. |
| <meta.schema plugin="org.eclipse.jdt.ui" id="semanticTokens" name="%semanticTokens"/> | ||
| </appInfo> | ||
| <documentation> | ||
| [Enter description of this extension point.] |
There was a problem hiding this comment.
This will need to be filled
|
|
||
| import org.eclipse.jdt.core.dom.CompilationUnit; | ||
|
|
||
| public interface SemanticTokensProvider { |
There was a problem hiding this comment.
Please use ISemanticTokensProvider for consistency with other interfaces
|
@mickaelistria @martinlippert updated the PR for Mickael's comments |
|
@BoykoAlex Thanks for incorporating the comments from @mickaelistria (and thanks a lot @mickaelistria for taking a look, much appreciated). Now looking for a JDT UI committer to pick this up and provide feedback, merge, or whatever makes sense to move this forward. |
| import java.util.Collection; | ||
|
|
||
| import org.eclipse.jdt.core.dom.CompilationUnit; | ||
|
|
| } | ||
|
|
||
| private Highlighting findHighlighting(String preferenceKey) { | ||
| for (int i = 0; i < fJobSemanticHighlightings.length; i++) { |
There was a problem hiding this comment.
this codes looks like fJobSemanticHighlightings and fJobHighlightings needs to be of same size, which is documented no where. You may even better use a single Collection containing tuples to make that clear.
|
|
||
| /** | ||
| * XXX Hack for performance reasons (should loop over fJobSemanticHighlightings can call consumes(*)) | ||
| * @since 3.5 | ||
| */ | ||
| private Highlighting fJobDeprecatedMemberHighlighting; | ||
|
|
||
| private Highlighting[] fEditorHighlightings; |
There was a problem hiding this comment.
does this duplicate a hack? better find a solution?
|
This change is rather complex to review, fails the automated tests and does not come with junit testcases. |
Fixes #1594
Extension point to contribute semantic tokens into the JDT Java editor.