Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if/else to switch to handle null scenarios #1726

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jjohnstn
Copy link
Contributor

What it does

See issue.

How to test

See issue.

Author checklist

- for < JVM 21 add an if/else that checks for null
- for JVM 21 and up, add case null
- modified SwitchFixCore and modified tests in CleanUpTest12
  to also not qualify enums if the switch value is an enum
- fixes eclipse-jdt#1714
@jjohnstn jjohnstn self-assigned this Oct 21, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Oct 21, 2024
@jjohnstn jjohnstn added this to the 4.34 M3 milestone Oct 21, 2024
@jjohnstn
Copy link
Contributor Author

Test is known to randomly fail.

@jjohnstn jjohnstn merged commit b8fb344 into eclipse-jdt:master Oct 21, 2024
7 of 10 checks passed
@jjohnstn jjohnstn deleted the switchnull branch October 21, 2024 20:14
@jjohnstn jjohnstn added the noteworthy Noteworthy feature label Oct 23, 2024
jjohnstn added a commit to jjohnstn/www.eclipse.org-eclipse that referenced this pull request Oct 23, 2024
akurtakov pushed a commit to eclipse-platform/www.eclipse.org-eclipse that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working noteworthy Noteworthy feature
Projects
None yet
1 participant