Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No hard code #1729

Closed
wants to merge 3 commits into from
Closed

Conversation

jannisCode
Copy link
Contributor

What it does

This commit has a refachoring for the filters in the Call Hierarchy

Author checklist

@iloveeclipse
Copy link
Member

May I ask for a proper commit messages and also appropriate PR description?
This is not OK:

0ce9a03 better code maybe??
a6dc859 Revert "better code maybe??"
b8d2ce1 Better code now (Less hard code)

See https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

@jannisCode jannisCode closed this Oct 22, 2024
@jannisCode jannisCode reopened this Oct 22, 2024
@jannisCode
Copy link
Contributor Author

I am really sorry i had some problems with my commits and git in general. Thats why I created a new PR with the right commit and a better commit message.
Again I am really sorry for the confusion.

@jannisCode jannisCode closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants