Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure v2 used only when possible #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make sure v2 used only when possible #36

wants to merge 1 commit into from

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Nov 8, 2024 •
edited
Loading

This PR tries to solve some problems

  • Do not try to use v2 by default for subscribe/set, as it does not work for target values
  • Add an extra check if using v2 - to give errors if we try to set anything else than actual value.

No extra testcases added for the non-async use-case as we do not have any test framework there AFIAK

@erikbosch erikbosch marked this pull request as ready for review November 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmittag lukasmittag Awaiting requested review from lukasmittag

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikbosch