-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action for Dash License Check #9
Conversation
Signed-off-by: Andre Weber <andre.weber3@etas.com>
Some thoughts:
As I understand you can as an Eclipse committer request review of licenses, like the ones below (see https://github.com/eclipse/dash-licenses). Do we want to do that? Any input @SebastianSchildt ?
|
I tried creating a request for a review, let see what happens
|
So currently I create the tickets manually form time to time and do not release/allow you to release before master/main is clear. I think a next step - at least I feel kuksa databroker side is robust enough for this - we should put a dash token as organisations secret and extend out dash action, that it can optionally create the tickets itself. basically automating what you did there. For now I would not require everything being cleared in PRs. What I currently do, if I see just 1 or 2 new dependencies in a PR, I manually check the if. license "seems ok". The problem with waiting for clearing is, often it is fast (like < 1 hour, and auto cleared by scan), but sometimes it can take 2,3 weeks) So far in recent we never had the situation that we needed to roll back a change. |
Closes: #8